Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 33a3669 | Commit Preview URL Branch Preview URL |
Mar 01 2026, 04:36 AM |
…m ATTACK rows (#1083) Remove CheckmateDetector, DiscoveredCheckDetector, and DoubleCheckDetector from the indexer. CHECKMATE, DISCOVERED_CHECK, and DOUBLE_CHECK are now derived at query/response time from stored ATTACK rows, just like FORK and DISCOVERED_ATTACK. - Delete the three detector classes and their unit tests - Remove from IndexerModule.motifDetectors() and BUILD.bazel - GameFeatureDao.queryOccurrences(): extend SQL filter to exclude stale stored rows ('FORK', 'CHECKMATE', 'DISCOVERED_CHECK', 'DOUBLE_CHECK', 'DISCOVERED_ATTACK'); add five derivation helpers that derive all ATTACK-based motifs in post-processing - Add GameFeatureDaoTest cases for each new derivation and for stale-row filtering - Update FullMotifDetectorTest: remove 3 detectors from setUp(), remove CHECKMATE from expected motif set, add CHECKMATE to absent set, delete extractFeatures_checkmate_Ra5() - Update MotifE2ETest, IndexE2ETest, ReanalysisE2ETest: remove deleted detector imports Closes #1083
aaylward
force-pushed
the
fix/issue-1083-attack-single-source-of-truth
branch
from
426814d to
33a3669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckmateDetector,DiscoveredCheckDetector, andDoubleCheckDetectorfrom the indexer pipeline (Option B from chore(one_d4): resolve dual-detection inconsistency for DISCOVERED_ATTACK, CHECKMATE, and DOUBLE_CHECK motifs #1083)GameFeatureDao.queryOccurrences()SQL now excludes all five derived-motif types from direct storage lookup; post-processing derives all five from ATTACK rowsDetails
CheckmateDetector,DiscoveredCheckDetector,DoubleCheckDetector+ their test filesmotif NOT IN ('FORK', 'CHECKMATE', 'DISCOVERED_CHECK', 'DOUBLE_CHECK', 'DISCOVERED_ATTACK')to exclude both new and stale stored rowsderiveDiscoveredAttackOccurrences,deriveCheckmateOccurrences,deriveDiscoveredCheckOccurrences,deriveDoubleCheckOccurrencesTest plan
GameFeatureDaoTestcases cover each derivation path and stale-row filteringMotifE2ETest.checkmate_motifDetectedWithIsMateTruecontinues to pass (derived from ATTACK rows)FullMotifDetectorTestupdated to reflect CHECKMATE no longer indexed at extract timeCloses #1083