Conversation
…* fields GameTable was gating badge display on legacy has* boolean fields (e.g. hasFork, hasPin) that the backend dropped when motifs moved from game_features columns to the motif_occurrences table. The occurrences map is already on the wire — switch to Object.keys(game.occurrences) as the single source of truth and remove the now-dead has* fields from GameRow and all test fixtures.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | e2d6d6c | Commit Preview URL Branch Preview URL |
Mar 01 2026, 02:51 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GameTablewas gating badge display on legacyhas*boolean fields (e.g.hasFork,hasPin) that the backend dropped when motifs moved fromgame_featurescolumns to themotif_occurrencestableoccurrences: Record<string, OccurrenceRow[]>map is already returned by the API — switchGameTableto derive badge presence fromObject.keys(game.occurrences ?? {})has*fields from theGameRowtype and all test fixtures;occurrencesis now the single source of truthTest plan
npm run typecheck— cleannpm test— 46/46 passing/gamespage against live API