test(one_d4): add DataFusionContractTest — SQL equivalence for all 16 motifs#1096
Merged
test(one_d4): add DataFusionContractTest — SQL equivalence for all 16 motifs#1096
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | ce529c5 | Commit Preview URL Branch Preview URL |
Mar 08 2026, 08:51 PM |
… motifs Seeds H2 with one game per motif (11 stored + 5 ATTACK-derived) and runs every ChessQL expression type through both SqlCompiler and DataFusionSqlCompiler, asserting identical result sets. Covers all 16 motifs, comparison, IN, AND/OR/NOT, sequence, and ORDER BY expressions.
aaylward
force-pushed
the
feat/motif-query-scaffold
branch
from
59ad721 to
d1a210f
Compare
aaylward
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
DataFusionContractTest, a 33-test hermetic suite that seeds H2 with one game per motif and asserts thatDataFusionSqlCompiler(inline SQL literals) produces identical result sets toSqlCompiler(JDBC?bind params) for every ChessQL expression type.Coverage:
>=,<,=) and string (=,!=)sequence(pin THEN check))motif_count(check) ASC/DESC)Each test also asserts
dfCompiler.parameters().isEmpty()— confirming no bind params are emitted.Test plan
bazel test //domains/games/apis/one_d4:contract_tests— 33 tests passbazel test //domains/games/apis/one_d4/...— all 34 one_d4 tests pass