Conversation
…gzwang/overloaded detectors Pin and skewer detectors now only fire when the attacker (pinning/skewering piece) is the piece that just moved, eliminating detections of pre-existing tactics that the current move had nothing to do with. The destination square is parsed from the SAN lastMove via a shared BoardUtils.destinationSquare() helper. OverloadedPieceDetector and ZugzwangDetector removed from the build and all test and production wiring. UI query help text and GameDetailPanel motif color map updated to match. GameDetailPanel motif list now groups occurrences by move (one row per ply) with all motif badges for that move shown inline, avoiding vertical explosion when multiple tactics occur on the same move.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 9aca2f7 | Commit Preview URL Branch Preview URL |
Mar 03 2026, 04:13 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastMovevia a new sharedBoardUtils.destinationSquare()helper.ZugzwangDetectorandOverloadedPieceDetector: deleted from source, BUILD, all test wiring,IndexerModule, UI color map, and query help text.GameDetailPanelmotif list grouped by move: instead of one row per occurrence (causing vertical explosion when multiple tactics fire on the same move), the list now shows one row per ply with all motif badges for that move inline. Each badge is individually clickable; prev/next motif nav still steps through individual occurrences.Test plan
bazel test //domains/games/apis/one_d4/...— all 31 tests passnpm testin1d4_web— all 54 tests passnpm run typecheck— clean./scripts/format-all— cleanbazel test //...— no failures