Skip to content

refactor(diff-build): simplify script and add bazel config change detection#1108

Merged
aaylward merged 7 commits intomainfrom
shak
Mar 4, 2026
Merged

refactor(diff-build): simplify script and add bazel config change detection#1108
aaylward merged 7 commits intomainfrom
shak

Conversation

@aaylward
Copy link
Copy Markdown
Collaborator

@aaylward aaylward commented Mar 4, 2026

Summary

  • Rewrites diff-build to use bazel run @bazel-diff instead of downloading a jar at runtime
  • Adds early-exit path to run a full //... build+test when .bazelversion or .bazelrc changes (bazel-diff isn't reliable across Bazel config changes)
  • Adds --skip_incompatible_explicit_targets so cross-platform targets (iOS, macOS-only) are silently skipped on Linux CI runners rather than failing
  • Replaces bash array loops with bazel query to categorize impacted targets into tests vs builds
  • Updates Bazel module dependencies

Test plan

  • Branch CI passes with bazel-diff path
  • Verify full-build fallback triggers correctly if .bazelrc is modified in a future PR

…ection

- Rewrite diff-build to use bazel run @bazel-diff instead of a downloaded jar
- Add early-exit full build/test when .bazelversion or .bazelrc changes
- Add --skip_incompatible_explicit_targets to handle cross-platform targets
- Use bazel query to categorize targets instead of bash loops
- Update Bazel module dependencies
@aaylward aaylward enabled auto-merge (squash) March 4, 2026 22:47
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 4, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
1d4-web 09020a1 Commit Preview URL

Branch Preview URL
Mar 04 2026, 11:17 PM

@aaylward aaylward disabled auto-merge March 4, 2026 22:50
@aaylward aaylward enabled auto-merge (squash) March 4, 2026 23:18
@aaylward aaylward merged commit 932d807 into main Mar 4, 2026
12 checks passed
@aaylward aaylward deleted the shak branch March 4, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant