llama.cpp patch

[JeremyBickel]

I'm sorry for this non-standard bug report. I can't find the file in question in the directory structure here, but the file stands out enough that I think this report will be useful to someone. There's a patch that's done in go-llama and go-llama-stable that causes a build failure because the patch file itself seems to be wrong. I don't know much about them, but it refers to two different files (common.cpp and common.h), and it tries to apply the patch for both these files - it applies it all on common.cpp. It caused me hours of rebuilding over and over to trace it down. So, just separate it into two patches or manually apply it - it's not very complex. NOTE: It applies to different files between the two go* branches. In llama, it's the "common" files located from the main directory, but in llama-stable, it's in the "common" files located from the examples directory.

I hope this helps someone.

[localai-bot]

⚠️⚠️⚠️⚠️⚠️

Hi! I'm a bot running with LocalAI ( a crazy experiment of @mudler ) - please beware that I might hallucinate sometimes!

but.... I can also be funny or helpful 😸 and I can provide generally speaking good tips or places where to look after in the documentation or in the code based on what you wrote in the issue.

Don't engage in conversation with me,
I don't support (yet) replying!

⚠️⚠️⚠️⚠️⚠️

Thank you for the detailed context and issue description. I will try to help you with this issue as best as I can.
Based on your description, it seems like there is a patch that is causing issues when applied to both go-llama and go-llama-stable. The patch refers to two different files (common.cpp and common.h), but it tries to apply the patch for both these files - it applies it all on common.cpp.
To fix this issue, you can try the following steps:

1. Check if the patch is still relevant and necessary for the current version of go-llama and go-llama-stable. If not, you can remove the patch entirely or update it to a newer version that is compatible with the current versions of these libraries.
2. If the patch is still necessary, you can try separating it into two separate patches - one for common.cpp and another for common.h. Apply each patch separately to their respective files in the go-llama and go-llama-stable directories.
3. If the issue persists after applying the separate patches, you can try manually applying the patch by editing the relevant files directly in the go-llama and go-llama-stable directories. Make sure to keep a backup of the original files before making any changes.
4. Once you have applied the patch manually, verify that the build is successful and that the issue has been resolved.
   I hope this helps you resolve the issue with the go-llama and go-llama-stable libraries. Let me know if you need further assistance or if there are any other questions I can help you with.

Sources:

• https://github.com/go-skynet/LocalAI/tree/master/Makefile
• https://github.com/go-skynet/LocalAI/tree/master/.gitignore

[blob42]

Hi, are you doing a parallel compile ? Try compiling with a single job it should solve the issue

[JeremyBickel]

@blob42 No, it wasn't a parallel compile. I appreciate the attempt to help, but I didn't leave you enough information. At the time, I thought it would be obvious, so I didn't leave all the details. Now, I barely remember this. Given the date of this report and the fact that it had to do with a patch, It's probably taken care of. If someone recognizes the issue in the future, feel free to reopen this, even though I didn't give enough information about it - it might help? Thanks again, b.