Skip to content

fix(react-ui): force .check() on hidden Toggle input in fits-filter e2e #10031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudler merged 2 commits into from
May 27, 2026
+4 −2
Merged

fix(react-ui): force .check() on hidden Toggle input in fits-filter e2e #10031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e8f46
fix(react-ui): force .check() on hidden Toggle input in fits-filter e2e
mudler May 27, 2026
496d497
fix(react-ui): click visible Toggle track in fits-filter e2e
mudler May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/http/react-ui/e2e/models-gallery.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,9 @@ test.describe('Models Gallery - Fits In GPU Filter', () => {
test('enabling fits filter hides models that exceed available VRAM', async ({ page }) => {
await expect(page.locator('tr', { hasText: 'stablediffusion-model' })).toBeVisible()

await page.getByLabel('Fits in GPU').check()
// The shared <Toggle> visually hides its native input (opacity:0;w:0;h:0),
// so .check() can't interact with it directly — click the visible track.
await page.locator('label.filter-bar-group__toggle', { hasText: 'Fits in GPU' }).locator('.toggle__track').click()

await expect(page.locator('tr', { hasText: 'stablediffusion-model' })).toHaveCount(0)
await expect(page.locator('tr', { hasText: 'llama-model' })).toBeVisible()
Expand All @@ -298,7 +300,7 @@ test.describe('Models Gallery - Fits In GPU Filter', () => {
})

test('fits filter state persists after reload', async ({ page }) => {
await page.getByLabel('Fits in GPU').check()
await page.locator('label.filter-bar-group__toggle', { hasText: 'Fits in GPU' }).locator('.toggle__track').click()
await page.reload()
await expect(page.getByLabel('Fits in GPU')).toBeChecked()
})
Expand Down
Loading