Skip to content

Conversation

@mudler
Copy link
Owner

@mudler mudler commented Nov 25, 2025

Description

This PR supercedes #7357

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

…45a'

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for localai ready!

Name Link
🔨 Latest commit d455ffd
🔍 Latest deploy log https://app.netlify.com/projects/localai/deploys/69261ca114471e0008d67a03
😎 Deploy Preview https://deploy-preview-7358--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hayden3456
Copy link

hayden3456 commented Nov 26, 2025

PR Documentation Suggestions

CategorySuggestion                                                                                                                                    Impact
Dependency update
Update llama.cpp version in dependencies doc

Update the Llama.cpp Dependency section to reflect the new version of llama.cpp
being used in this update.

File: docs/dependencies.md

--- a/docs/dependencies.md
+++ b/docs/dependencies.md
@@ -1,3 +1,3 @@
 ## Llama.cpp Dependency

 

-The project relies on the `llama.cpp` library for backend processing. Ensure you have the correct version specified in the Makefile.

+The project relies on the `llama.cpp` library for backend processing. Ensure you have the correct version specified in the Makefile, which is now `583cb83416467e8abf9b37349dcf1f6a0083745a`.

Actions: Accept | Reject

Suggestion importance[1-10]: 9

__

Why: This suggestion updates existing documentation to reflect a critical change in the version of a key dependency, llama.cpp, ensuring users are aware of the correct version to use.

High
Build instructions
Update build instructions for new file copies

Update the build instructions to include the new files being copied to the
grpc-server directory as part of the preparation script.

File: docs/build-instructions.md

--- a/docs/build-instructions.md
+++ b/docs/build-instructions.md
@@ -1,3 +1,3 @@
 ### Building the gRPC Server

 

-To build the gRPC server, ensure all necessary files are copied to the `llama.cpp/tools/grpc-server/` directory.

+To build the gRPC server, ensure all necessary files are copied to the `llama.cpp/tools/grpc-server/` directory. The preparation script now includes copying all files from `llama.cpp/tools/server/` to `llama.cpp/tools/grpc-server/`.

Actions: Accept | Reject

Suggestion importance[1-10]: 8

__

Why: The suggestion updates existing build instructions to reflect changes in the preparation script, which is important for users to successfully build the gRPC server with the correct files.

Medium
Api change
Document change from format_rerank to format_prompt_rerank

Update the API changes documentation to reflect the change from format_rerank to
format_prompt_rerank in the backend service implementation.

File: docs/api-changes.md

--- a/docs/api-changes.md
+++ b/docs/api-changes.md
@@ -1,3 +1,3 @@
 ### Backend Service Implementation

 

-The backend service processes tasks using the `format_rerank` function.

+The backend service processes tasks using the `format_prompt_rerank` function, replacing the previous `format_rerank` function.

Actions: Accept | Reject

Suggestion importance[1-10]: 7

__

Why: This suggestion updates existing API documentation to reflect a change in function usage, which is important for developers to understand the new behavior of the backend service.

Medium

Any Thoughts on My New Idea?

I'm experimenting with automatically updating documentation as code changes. I won't post this anymore on this project without permission. I'm looking for some honest feedback about if this is useful or not. I know the logic could give better suggestions, but I want to check if I'm barking up the right tree.

@mudler mudler merged commit 7a94d23 into master Nov 26, 2025
37 of 38 checks passed
@mudler mudler deleted the deps/llama.cpp-583cb83416467e8abf9b37349dcf1f6a0083745a branch November 26, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants