Skip to content

Conversation

@dave-gray101
Copy link
Collaborator

@dave-gray101 dave-gray101 commented Jul 28, 2023

Description

This PR adds a pair of optional query string parameters to the GET /models endpoint.

  • excludeConfigured, true by default, any model files that have a matching configuration file are not included in the list
  • filter If this parameter is specified, it is interpreted as a regex, and used to filter the models by name. Empty by default.

Special Thanks to KrisD in Discord, who requested the defaults operate in this way 👍

Notes for Reviewers
CI Issues fixed 🎉

Signed commits

  • Yes, I signed my commits.

@dave-gray101 dave-gray101 requested a review from mudler July 28, 2023 06:00
@dave-gray101
Copy link
Collaborator Author

Since I'm touching the file extension list, I also added a fix for #801

@dave-gray101 dave-gray101 enabled auto-merge (squash) July 30, 2023 01:31
@dave-gray101 dave-gray101 requested a review from mudler July 30, 2023 16:54
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@dave-gray101 dave-gray101 merged commit ce8e9dc into mudler:master Jul 31, 2023
@mudler mudler added the enhancement New feature or request label Aug 2, 2023
@dave-gray101 dave-gray101 deleted the feat-filter-model-list-endpoint branch February 21, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants