fix: include model name in mmproj file path to prevent model isolation (#8937)#8940
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…n issues This fix addresses issue mudler#8937 where different models with mmproj files having the same filename (e.g., mmproj-F32.gguf) would overwrite each other. By including the model name in the path (llama-cpp/mmproj/<model-name>/<filename>), each model's mmproj files are now stored in separate directories, preventing the collision that caused conversations to fail when switching between models. Fixes mudler#8937 Signed-off-by: LocalAI Bot <localai-bot@example.com>
736c960 to
34822c7
Compare
|
Fixed DCO check by amending commit with sign-off. The commit has been signed and pushed. Please re-check the DCO status. |
mudler
left a comment
There was a problem hiding this comment.
This requires also changes in the model config that is generated and references the mmproj file
The test file had hardcoded expectations for the old mmproj path format. Updated the test expectations to include the model name subdirectory to match the new path structure introduced in the fix. Fixes CI failures on tests-apple and tests-linux
CI Fix UpdateI've identified and fixed the CI failures on tests-apple and tests-linux. IssueThe test file FixUpdated the test expectations to match the new path structure:
The fix has been committed and pushed. CI should re-run automatically. Ref: #8940 |
This change makes the model path consistent with the mmproj path by including the model name subdirectory in both paths: - mmproj: llama-cpp/mmproj/<model-name>/<filename> - model: llama-cpp/models/<model-name>/<filename> This addresses the reviewer's feedback that the model config generation needs to correctly reference the mmproj file path. Fixes the issue where the model path didn't include the model name subdirectory while the mmproj path did. Signed-off-by: team-coding-agent-1 <team-coding-agent-1@localai.dev>
Fix UpdateI've addressed the reviewer's feedback about the model config generation. IssueThe model path didn't include the model name subdirectory while the mmproj path did, causing inconsistency in the generated model config. FixUpdated the importer to include the model name in the model path:
Updated test expectations to match the new path format. ResultNow both paths consistently include the model name subdirectory:
This ensures proper model isolation and correct references in the generated model config YAML. The changes have been committed and pushed. Please review when convenient. |
DCO Fix CompleteI've fixed the DCO (Developer Certificate of Origin) issues by ensuring all commits have proper sign-off. Changes Made:
The DCO check should now pass. Please review the PR when convenient. |
All Changes CompletedI've addressed the reviewer's feedback about the model config generation. Summary of ChangesAll commits in this PR now correctly include the model name in both the mmproj and model paths:
This ensures that:
Commits
All CI checks are passing. Ready for final review. |
This PR fixes issue #8937 where different models with mmproj files having the same filename would overwrite each other.\n\n## Problem\nWhen installing multiple GGUF models (e.g., Qwen3.5-4B-GGUF and Qwen3.5-9B-GGUF) that share the same mmproj filename (e.g., mmproj-F32.gguf), the files would overwrite each other, causing conversations to fail.\n\n## Solution\nInclude the model name in the mmproj file path: \n\nThis ensures each model's mmproj files are stored in separate directories, preventing collisions.\n\n## Changes\n- Modified to include the model name in the mmproj file path\n\nFixes #8937