fix: use SetFunctionCallNameString when forcing a specific tool (3 sites)#9526
Merged
mudler merged 3 commits intomudler:masterfrom Apr 24, 2026
Merged
Conversation
Anai-Guo
added a commit
to Anai-Guo/LocalAI
that referenced
this pull request
Apr 25, 2026
Follows up on mudler#9526 (the 3-site setter fix) by addressing the remaining clause in mudler#9508 — string mode and OpenAI-spec specific-function shape both silently failed in the /v1/chat/completions parsing path.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows up on #9509 (merged) which fixed the same bug in
MergeOpenResponsesConfig.Three additional call sites were using
SetFunctionCallString(name)(which writes the mode field, e.g."none"/"auto"/"required") when they should be usingSetFunctionCallNameString(name)(which writes the specific function name field read byShouldCallSpecificFunction/FunctionToCall).Net effect of the original code: when a caller sends
tool_choice: {type: "function", function: {name: "my_tool"}}via these three endpoints, the grammar-based forcing is silently never engaged because the name ends up in the wrong config field.Sites fixed
core/http/endpoints/anthropic/messages.go/v1/messagescore/http/endpoints/openai/realtime_model.gocore/http/endpoints/openresponses/responses.go/v1/responses(non-middleware path)In each case the change is:
Tracked in issue #9508.
Test plan
tool_choice: {"type": "function", "function": {"name": "my_tool"}}via Anthropic/v1/messagesendpoint and verify grammar-based forcing engages/v1/responsesendpoint🤖 Generated with Claude Code