Close Hugging Face scan response body#9818
Merged
Merged
Conversation
massy-o
commented
May 14, 2026
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer results.Body.Close() |
Contributor
Author
There was a problem hiding this comment.
Self-review: Deferring Body.Close immediately after a successful http.Get ensures the response is released on both the non-200 error path and the normal JSON decode path.
Signed-off-by: massy-o <telitos000@gmail.com>
massy-o
force-pushed
the
codex/close-hf-scan-body
branch
from
99055a8 to
00f54b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
HuggingFaceScan reads the response body but did not close it. Deferring Body.Close() after a successful http.Get releases the underlying connection resources on both success and error status paths.
Testing