Validate video image URLs before download#9819
Merged
Merged
Conversation
Signed-off-by: massy-o <telitos000@gmail.com>
massy-o
commented
May 14, 2026
| var videoDownloadClient = http.Client{Timeout: 30 * time.Second} | ||
|
|
||
| func downloadFile(url string) (string, error) { | ||
| if err := utils.ValidateExternalURL(url); err != nil { |
Contributor
Author
There was a problem hiding this comment.
Self-review: This mirrors the existing image endpoint URL policy for video inputs, so private/link-local/metadata hosts are rejected before the server issues an outbound request.
mudler
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The image generation path already validates external URLs before fetching them. The video endpoint accepted http(s) start/end image URLs but downloaded them directly, which left the endpoint with a less strict URL-fetching policy. Reusing ValidateExternalURL blocks private, loopback, link-local, and metadata host targets before fetching.
Testing
Note: go test ./core/http/endpoints/localai currently fails in this checkout because github.com/mudler/LocalAI/pkg/grpc/proto is not present/generated.