chore(acestep-cpp): bump pin to ed53caf and adapt wrapper to new API#9908
Merged
Conversation
The new ace-step.cpp revision moves backend initialization inside each `*_load` call and drops the separate `DiTGGMLConfig` argument from `dit_ggml_load` (config now lives in `DiTGGML::cfg`, populated from GGUF metadata at load time). Drop the now-removed `*_init_backend` calls and replace `g_dit_cfg` accesses with `g_dit.cfg`. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Claude:claude-opus-4-7 [Claude Code]
mudler
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes / fixes #9874 (the auto-bump PR that failed to compile after the upstream API changed).
The new ace-step.cpp revision (
ed53caf) refactors how model contexts are initialized:*_loadfunction — the separatedit_ggml_init_backend,qwen3_init_backend, andcond_ggml_init_backendhelpers no longer exist.dit_ggml_loadno longer takes a separateDiTGGMLConfigargument. The config now lives onDiTGGML::cfgand is populated from GGUF metadata at load time.This PR adapts the C++ wrapper accordingly: drops the three
*_init_backendcalls, simplifies thedit_ggml_loadcall, removes the now-unusedg_dit_cfgstatic, and rewrites its remaining readers asg_dit.cfg.Upstream change range: https://github.com/ace-step/acestep.cpp/compare/e0c8d75a672fca5684c88c68dbf6d12f58754258..ed53caf164e4492a5620b2e3f2264629cf66da24
Test plan
make libgoacestepcpp-fallback.sobuilds clean locally (cmake 3.28 / g++ 13.3); only pre-existing-Wshadowwarnings insideggml-backend.hremain.tests-acestep-cppand thebackend-jobs-multiarch/backend-jobs-singlearch(-cpu-acestep-cpp, hipblas, arm64) jobs that previously failed on chore: ⬆️ Update ace-step/acestep.cpp toed53caf164e4492a5620b2e3f2264629cf66da24#9874.