[utils] Fail immediately on extraction errors#9926
Merged
Conversation
Setting ContinueOnError to false ensures that ExtractArchive does not leave the model or backend directory in an inconsistent state if a partial failure occurs. This improves robustness against malformed archives or unexpected I/O issues during installation. Signed-off-by: RinZ27 <222222878+RinZ27@users.noreply.github.com>
mudler
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensuring archive extraction integrity is critical for maintaining a stable runtime environment. This change modifies
ExtractArchiveto disable theContinueOnErrorflag. By failing immediately upon any extraction error, we prevent models or backends from being left in a partially extracted and inconsistent state, which could otherwise lead to undefined behavior or silent failures during model loading.Notes for Reviewers
The modification is focused strictly on the
mytarconfiguration withinpkg/utils/untar.go. Existing archive tests were verified to ensure no regressions in path validation or standard extraction logic.Signed commits