Skip to content

Fix kokoros backend build break from Backend trait drift#9972

Merged
mudler merged 2 commits into
masterfrom
copilot/fix-tests-kokoros-job
May 24, 2026
Merged

Fix kokoros backend build break from Backend trait drift#9972
mudler merged 2 commits into
masterfrom
copilot/fix-tests-kokoros-job

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 24, 2026

tests-kokoros started failing because the Rust kokoros backend no longer satisfied the generated Backend trait after AudioToAudioStream was added to the shared gRPC surface. The backend implementation was missing both the new associated stream type and RPC method.

  • Root cause

    • backend/rust/kokoros/src/service.rs did not implement newly required trait items:
      • AudioToAudioStreamStream
      • audio_to_audio_stream(...)
  • Change made

    • Added minimal, explicit UNIMPLEMENTED stubs in KokorosService to keep interface parity without changing kokoros runtime behavior.
    • Followed existing backend pattern for unsupported RPCs.
  • Why this is minimal

    • No behavior change for supported kokoros features.
    • No proto or workflow edits; only trait conformance in the kokoros service implementation.
type AudioToAudioStreamStream = ReceiverStream<Result<backend::AudioToAudioResponse, Status>>;

async fn audio_to_audio_stream(
    &self,
    _: Request<tonic::Streaming<backend::AudioToAudioRequest>>,
) -> Result<Response<Self::AudioToAudioStreamStream>, Status> {
    Err(Status::unimplemented("Not supported"))
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.pyke.io
    • Triggering command: /home/REDACTED/work/LocalAI/LocalAI/backend/rust/kokoros/target/release/build/ort-sys-7d323129fad21ae4/build-script-main /home/REDACTED/work/LocalAI/LocalAI/backend/rust/kokoros/target/release/build/ort-sys-7d323129fad21ae4/build-script-main c-rendered-ansi,-f ctions -fdata-seconftest.er1 &#43; ocal�� (dns block)
    • Triggering command: /home/REDACTED/work/LocalAI/LocalAI/backend/rust/kokoros/target/release/build/ort-sys-7d323129fad21ae4/build-script-main /home/REDACTED/work/LocalAI/LocalAI/backend/rust/kokoros/target/release/build/ort-sys-7d323129fad21ae4/build-script-main -o util.o /tmp/ccSMj8Xi.s 1.11/lame-3.100/include e \(.*(DEPDIR).*-I/home/REDACTED/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/mp3lame-sys-as 1.11/lame-3.100/libmp3lame /usr/bin/sed 1.11/lame-3.100/mpglib .2.2/opus/includ-W -1949cf8c6b5b557-I _FLP.c.o f/mp�� s/g f/mp3lame-sys-0.-I /bin/sh f/mp3lame-sys-0.sort .2.2/opus/silk /index.crates.io-I re_FLP.c.o (dns block)
    • Triggering command: /home/REDACTED/work/LocalAI/LocalAI/backend/rust/kokoros/target/release/build/ort-sys-7d323129fad21ae4/build-script-main /home/REDACTED/work/LocalAI/LocalAI/backend/rust/kokoros/target/release/build/ort-sys-7d323129fad21ae4/build-script-main --color= /kokoros/target/.libs/libmp3lame.lai ex.crates.io-194/tmp/ccDEFvUS.s f/mp�� io-1949cf8c6b5b557f/audiopus_sys-0.2.2/opus/silk f/mp3lame-sys-0.1.11/lame-3.100/libmp3lame u/13/cc1 f/mp3lame-sys-0.llvm-config .2.2/opus/includ--prefix /index.crates.io-1949cf8c6b5b557-I u/13/cc1 f/mp�� cc -DHAVE_CONFIG_H -I. -I/home//home/REDACTED/.cargo/registry/src/index.crates.io-1949cf8c6b5b557git f/mp3lame-sys-0.1.11/lame-3.100/libmp3lame rgo/bin/as f/mp3lame-sys-0./usr/bin/gmake e /index.crates.io-f ild (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix failing GitHub Actions job tests-kokoros Fix kokoros backend build break from Backend trait drift May 24, 2026
Copilot finished work on behalf of mudler May 24, 2026 20:34
Copilot AI requested a review from mudler May 24, 2026 20:34
@mudler mudler marked this pull request as ready for review May 24, 2026 20:39
@mudler mudler merged commit 270c256 into master May 24, 2026
1 check passed
@mudler mudler deleted the copilot/fix-tests-kokoros-job branch May 24, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants