deps: use mudler/go-libp2p-pubsub fork to enable pubsub over relayed conns#1027
Merged
Merged
Conversation
…conns Upstream go-libp2p-pubsub silently drops every pubsub peer whose only connection to the local host is network.Limited (i.e. via a libp2p relay/circuit-v2 path) — three filters in handlePendingPeers, watchForNewPeers, and handleNewPeer each gate strictly on network.Connected. NAT-traversed clusters that get a working AutoRelay connection but where DCUtR hole-punching doesn't succeed (e.g. QEMU slirp NAT, double-NAT residential setups) therefore see their libp2p hosts as "connected both ways" while the ledger never propagates. Use mudler/go-libp2p-pubsub#feat/allow-pubsub-over-limited-connections (branch off upstream master) via a replace directive, until the upstream PR merges. Verified end-to-end with a standalone reproducer: two hosts behind a relay with a ConnectionGater that blocks all direct addresses, A→B pubsub message arrives in sub-second with the fork versus 60s+ timeout against stock pubsub. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream go-libp2p-pubsub silently drops every pubsub peer whose only connection to the local host is network.Limited (i.e. via a libp2p relay/circuit-v2 path) — three filters in handlePendingPeers, watchForNewPeers, and handleNewPeer each gate strictly on network.Connected. NAT-traversed clusters that get a working AutoRelay connection but where DCUtR hole-punching doesn't succeed (e.g. QEMU slirp NAT, double-NAT residential setups) therefore see their libp2p hosts as "connected both ways" while the ledger never propagates.
Use mudler/go-libp2p-pubsub#feat/allow-pubsub-over-limited-connections (branch off upstream master) via a replace directive, until the upstream PR merges. Verified end-to-end with a standalone reproducer: two hosts behind a relay with a ConnectionGater that blocks all direct addresses, A→B pubsub message arrives in sub-second with the fork versus 60s+ timeout against stock pubsub.
Upstream PR: libp2p/go-libp2p-pubsub#712 . Until gets merged we will use the fork