fix: don't call statfs on autofs mounts#359
Open
kreudom wants to merge 1 commit intomuesli:masterfrom
Open
Conversation
Calling statfs on autofs mounts will trigger a filesystem mount. This can hang duf and erroneously assign stats of the mounted filesystem to the autofs entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling statfs on autofs mounts will trigger a filesystem mount. This can hang duf (especially when mounting network filesystems) and erroneously assign the statfs results of the mounted filesystem to the autofs entry.
I also set the
Statfs_t.Typefield manually, so that autofs is correctly identified as a special filesystem.Fixes #250
Feels a bit hacky but I can't think of a better solution.