fix(dedent): stop removing spaces within non-indented lines#82
Open
Yanhu007 wants to merge 1 commit intomuesli:masterfrom
Open
fix(dedent): stop removing spaces within non-indented lines#82Yanhu007 wants to merge 1 commit intomuesli:masterfrom
Yanhu007 wants to merge 1 commit intomuesli:masterfrom
Conversation
The dedent function failed to set shouldOmit=false in the default (non-whitespace) case. This caused spaces within a line to be incorrectly removed when the line had less indentation than the computed minimum. For example, "This is an example" would become "Thisisan example" because the spaces between words were counted toward the omit quota. Fixes muesli#72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72
Problem
dedent.Stringincorrectly removes spaces from within lines that have less indentation than the minimum:Root Cause
The
dedentfunction setsshouldOmit = falseonly in the space/tab case (after omitting enough), but not in thedefaultcase. So after encountering the first non-whitespace character,shouldOmitremainstrue, and subsequent spaces in the same line are counted toward the omit quota.Fix
Set
shouldOmit = falsein thedefaultcase, so that only leading whitespace is eligible for removal.All existing tests pass.