[BUG] Table content keeps disappearing if "folded state" saving is enabled

[kazi-kavish]

This bug is identical to the issue no. 130 for which the OP has helpfully attached a demo GIF. The issue was closed on the assumption that it got resolved when the user "reset" some plugin.

But in fact, the issue still exists. It surfaces when the "Save code blocks folded state" option is toggled on.

Apparently, the OP had reset the plugin to default theme - which must have disabled the option and the issue appeared to have got resolved.

With the said option enabled, the following error shows up in the console at every keystroke and any text entered into a table cell gets wiped off!

app.js:1 RangeError: Position 909 is out of range for changeset of length 4
    at e.mapPos (app.js:1:266080)
    at remapRecord (plugin:codeblock-customizer:22524:32)
    at CodeBlockCustomizerPlugin.remapFolds (plugin:codeblock-customizer:22557:37)
    at e.update [as updateF] (plugin:codeblock-customizer:17174:16)
    at Object.update (app.js:1:279738)
    at e.computeSlot (app.js:1:290588)
    at Ie (app.js:1:283682)
    at e.field (app.js:1:289701)
    at e.update [as updateF] (plugin:codeblock-customizer:16939:43)
    at Object.update (app.js:1:279738)
    at e.computeSlot (app.js:1:290588)
    at Ie (app.js:1:283682)
    at new e (app.js:1:289557)
    at e.applyTransaction (app.js:1:290543)
    at e.get (app.js:1:285686)

[mugiwara85]

I'll check if I can reproduce it, and I'll get back to you. The other issue was closed, since the OP didn't replied anymore to my questions....

[mugiwara85]

@kazi-kavish I have to say, it is very hard to reproduce the error. During my test, I could only reproduce it once, and I did everything possible I could think of. I admit, have seen this error, but since, I couldn't reproduce it, it was very hard to fix it. I added some safety checks, which would (hopefully) prevent the error you described. However, as I said, since I couldn't reproduce the error, I couldn't check the fix either.
So, I would ask you, to please take the current main.js and overwrite yours with it, and check if you can still reproduce the issue. If yes, please send me every error messages the console displays. If you find a way to reliably reproduce the issue that would also help in fixing the problem!
Please test it, and report back!
Thanks!

[fanis]

I had the same RangeError in rare occasions. While looking into it I noticed this issue and can confirm the fix works.

Reproduction steps:

1. Add an out-of-range position to permanent-editor-folds.json (e.g., position 999999 for a ~765KB file)
2. Reload Obsidian
3. Edit the file - triggers RangeError: Position 999999 is out of range for changeset of length X

Testing the fix:
Downloaded main.js from master branch, which includes the if (oldPos > changes.length) continue; checks. Same reproduction steps no longer trigger the error.

Waiting for the next release to update properly. Thanks for the fix!

[mugiwara85]

@fanis That is a very clever way for reproducing the issue! Thanks for testing it. I want to add 1-2 things, and then finally release the new version.

[mugiwara85]

@kazi-kavish @fanis Fixed and released in version 1.4.0