-
-
Notifications
You must be signed in to change notification settings - Fork 308
Closed
Labels
breaking changeIntroduces changes that are not backward compatible.Introduces changes that are not backward compatible.component: accordionChanges related to the accordion component.Changes related to the accordion component.component: tabsChanges related to the tabs component.Changes related to the tabs component.
Milestone
Description
Currently it's possible to omit the value prop in accordion and tabs entirely, using the index (by position) implicitly as the value instead.
This causes a few issues:
- Unable to "truly" unmount a TabPanel when
keepMounted={false}[tabs]keepMounted={false}doesn't mount children but still mounts the root element #1872 - Mis-timed accordion animations [accordion] Opening animation isn't cancelled when a panel is initially open #1588
- Unable to SSR initially open accordion or initially active tab
- [tabs]
aria-controlsnot applied to the first tab if novalueis set #2096
(In Radix, value is required for both accordion and tabs)
michaldudak
Metadata
Metadata
Assignees
Labels
breaking changeIntroduces changes that are not backward compatible.Introduces changes that are not backward compatible.component: accordionChanges related to the accordion component.Changes related to the accordion component.component: tabsChanges related to the tabs component.Changes related to the tabs component.