[code-infra] Rely more on baseline prettier config#1183
Merged
oliviertassinari merged 2 commits intoDec 24, 2024
Conversation
oliviertassinari
requested review from
atomiks and
michaldudak
as code owners
Netlify deploy preview |
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Member
Author
|
Merging, this seems to be a trivial / no-brainer change. Upstream opportunity tackled with mui/material-ui#44854 (will help reverse the repository that own code-infra, /base-ui makes more sense to own docs-infra than /mui with the long-term product vision we push) |
oliviertassinari
changed the title
michaldudak
added
the
scope: code-infra
oliviertassinari
added
internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid duplication, so we can have more of a shared baseline.
For those who wonder what happened, it originated with #6. We had a similar issue with Pigment CSS, but we fixed it with mui/pigment-css#113.
Off-topic. We will likely need to change how
@mui/monorepo/prettier.configis handled and where the source is located, but logic duplication and best logic location are separate problems, e.g. mui/material-ui also has Tailwind CSS in its repo, it should have the plugin too.