[combobox][autocomplete] Add side and empty state attributes to Trigger
#3491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
type: enhancement
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
atomiks
force-pushed
the
feat/combobox-trigger-state-attrs
branch
from
75aa715 to
75d422b
Compare
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
feat/combobox-trigger-state-attrs
branch
from
75d422b to
d88aed4
Compare
Contributor
|
thanks! |
LukasTy
approved these changes
Dec 11, 2025
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
Works beautifully, nice work. 👍
Comment on lines
+36
to
+42
| "data-popup-side": { | ||
| "description": "Indicates which side the corresponding popup is positioned relative to its anchor.", | ||
| "type": "'top' | 'bottom' | 'left' | 'right' | 'inline-end' | 'inline-start' | null" | ||
| }, | ||
| "data-list-empty": { | ||
| "description": "Present when the corresponding items list is empty." | ||
| }, |
Member
There was a problem hiding this comment.
Maybe we should add these to the Autocomplete.Trigger as well? 🤔
Contributor
Author
There was a problem hiding this comment.
<Autocomplete.Trigger> is a re-export of <Combobox.Trigger>, so it inherits these already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These already exist on
InputCloses #3438