Skip to content

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 13, 2025

I was browsing the docs and felt that it was noticeably slower than it used to be. So, out of curiosity, I opened my dev tool. As it turned out, this is a regression from #3493. We introduced a complex CSS selector that breaks the CSS performance on the page:

body:has(.RootLayout) ::selection {

Two ways to reproduce the problem:

Open Select

Screen.Recording.2025-12-13.at.01.45.49.mov
SCR-20251213-clwn
  • PR: 26ms
SCR-20251213-cmes

Page transition

Screen.Recording.2025-12-13.at.01.49.40.mov
SCR-20251213-cnmx
  • PR: 54ms
SCR-20251213-cnjl

A must-watch on the topic: https://www.youtube.com/watch?v=nWcexTnvIKI. In our case:

SCR-20251213-cojp

My small contribution to v1 🎁. There is still stuff that feels slow, but one step at a time 😁

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. type: regression A bug, but worse, it used to behave as expected. performance labels Dec 13, 2025
@oliviertassinari oliviertassinari requested review from romgrk and removed request for atomiks and michaldudak December 13, 2025 00:54
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 13, 2025

  • vite-css-base-ui-example

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/react@3531
    
    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/utils@3531
    

commit: 1e79f9e

@mui-bot
Copy link

mui-bot commented Dec 13, 2025

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Dec 13, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 828e432
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/693cb934aa9150000825da37
😎 Deploy Preview https://deploy-preview-3531--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mui mui deleted a comment from netlify bot Dec 13, 2025
Copy link
Contributor

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! This is quite noticeable, even on a fast machine.

I was actually wondering why interactions felt "slightly" slower than before when browsing around earlier. On 4x-6x slowdown, it's pretty terrible and very noticeable 😬

@atomiks atomiks merged commit 650b61a into mui:master Dec 13, 2025
23 checks passed
@atomiks
Copy link
Contributor

atomiks commented Dec 13, 2025

I've deployed this change as it felt urgent, will be live shortly: https://base-ui.com

@oliviertassinari
Copy link
Member Author

There is still stuff that feels slow, but one step at a time

To illustrate my point, I made:

But I can't push this further, no time 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. performance type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants