-
-
Notifications
You must be signed in to change notification settings - Fork 369
[docs] Fix Recalculate style regression #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
828e432 to
1e79f9e
Compare
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find! This is quite noticeable, even on a fast machine.
I was actually wondering why interactions felt "slightly" slower than before when browsing around earlier. On 4x-6x slowdown, it's pretty terrible and very noticeable 😬
|
I've deployed this change as it felt urgent, will be live shortly: https://base-ui.com |
To illustrate my point, I made:
But I can't push this further, no time 😁 |
I was browsing the docs and felt that it was noticeably slower than it used to be. So, out of curiosity, I opened my dev tool. As it turned out, this is a regression from #3493. We introduced a complex CSS selector that breaks the CSS performance on the page:
Two ways to reproduce the problem:
Open Select
Screen.Recording.2025-12-13.at.01.45.49.mov
Page transition
Screen.Recording.2025-12-13.at.01.49.40.mov
A must-watch on the topic: https://www.youtube.com/watch?v=nWcexTnvIKI. In our case:
My small contribution to v1 🎁. There is still stuff that feels slow, but one step at a time 😁