Skip to content

[menu][docs] Fix detached triggers sample#3589

Merged
atomiks merged 3 commits intomui:masterfrom
chuganzy:menu-payload-doc
Dec 22, 2025
Merged

[menu][docs] Fix detached triggers sample#3589
atomiks merged 3 commits intomui:masterfrom
chuganzy:menu-payload-doc

Conversation

@chuganzy
Copy link
Copy Markdown
Contributor

This PR fixes a very minor error in the Menu doc.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Dec 21, 2025

  • vite-css-base-ui-example

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/react@3589
    
    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/utils@3589
    

commit: 317477d

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 21, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 317477d
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69489fe8b870b2000872e1d4
😎 Deploy Preview https://deploy-preview-3589--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@oliviertassinari oliviertassinari added component: menu Changes related to the menu component. type: bug It doesn't behave as expected. labels Dec 21, 2025
@oliviertassinari oliviertassinari changed the title [docs] Fix detached triggers sample in the Menu doc [menu][docs] Fix detached triggers sample Dec 21, 2025
@atomiks
Copy link
Copy Markdown
Contributor

atomiks commented Dec 21, 2025

The quotes here seem weird as well, could adjust these to remove the quotes:

const menus = {
  'file': ['New', 'Open', 'Save'],
  'edit': ['Undo', 'Redo', 'Cut', 'Copy', 'Paste'],
}

...

items: menus['file']
items: menus['edit']

@mui-bot
Copy link
Copy Markdown

mui-bot commented Dec 22, 2025

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@oliviertassinari
Copy link
Copy Markdown
Member

CircleCI failing https://app.circleci.com/pipelines/github/mui/base-ui/18429/workflows/708b87e2-dca2-4aa0-9551-465165a3640f

SCR-20251222-bvhl

looked like an intermittent bug with them. CircleCI context and sharing permissions with forks looks correct.

@atomiks atomiks merged commit 330817b into mui:master Dec 22, 2025
23 checks passed
@chuganzy chuganzy deleted the menu-payload-doc branch December 22, 2025 01:40
@brijeshb42 brijeshb42 added the docs Improvements or additions to the documentation. label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: menu Changes related to the menu component. docs Improvements or additions to the documentation. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants