-
-
Notifications
You must be signed in to change notification settings - Fork 352
[autocomplete][combobox] Support external items mapping #3594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
atomiks
wants to merge
2
commits into
mui:master
Choose a base branch
from
atomiks:fix/autocomplete-external-mapping
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cc15d1e to
3d51da5
Compare
3d51da5 to
9204b7b
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: autocomplete
Changes related to the autocomplete component.
component: combobox
Changes related to the combobox component.
PR: out-of-date
The pull request has merge conflicts and can't be merged.
type: enhancement
It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to support the cmdk library's composition style, without
itemsspecified on Root, and without needing to perform filtering externally:Right now,
Autocompletesupports this well, but you need to filter items externally yourself (viaAutocomplete.useFilter).Comboboxhas limited/partial support and does not work fully.Implementation
Each item returns
nullinternally when it's not rendered. Groups usehiddenattribute to prevent unmounting the children so their effects still run.Pros
Cons
itemsitems. Switching from no virtualization to virtualization already works naturally with the current/default API