-
-
Notifications
You must be signed in to change notification settings - Fork 369
[checkbox][radio][switch] Preserve modifier key properties in the change event #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[checkbox][radio][switch] Preserve modifier key properties in the change event #3935
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
5f8a7e4 to
f1c9fa7
Compare
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LukasTy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Could it also be relevant for the Radio component? 🤔
Greptile OverviewGreptile SummaryPreserves keyboard modifier key properties (shift, ctrl, alt, meta) in change events for checkbox, radio, and switch components by replacing
Confidence Score: 5/5
Important Files Changed
|
|
@mj12albert thank you!! |
Fixes #3875