[accordion] Add generic Value typing #4138
Merged
atomiks merged 3 commits intomui:masterfrom Feb 19, 2026
Merged
Conversation
atomiks
added
component: accordion
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
LukasTy
approved these changes
Feb 19, 2026
| export namespace AccordionRoot { | ||
| export type State = AccordionRootState; | ||
| export type Props = AccordionRootProps; | ||
| export type Value<TValue = any> = AccordionValue<TValue>; |
Member
There was a problem hiding this comment.
Nitpick: We could align on Value or TValue everywhere. 😃
| ); | ||
| }); | ||
| }) as { | ||
| <Value = any>(props: AccordionRoot.Props<Value>): React.JSX.Element; |
Member
There was a problem hiding this comment.
Doesn't it also need this part?
Suggested change
| <Value = any>(props: AccordionRoot.Props<Value>): React.JSX.Element; | |
| <Value = any>(props: AccordionRoot.Props<Value> & React.RefAttributes<HTMLDivElement>): React.JSX.Element; |
Contributor
Author
There was a problem hiding this comment.
The Props interface already includes the ref (after a change a couple months ago). It looks like the others should be updated to remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same updates as #3173 and #4033