[combobox] Fix combobox attributes during SSR#4179
Merged
atomiks merged 2 commits intomui:masterfrom Mar 3, 2026
Merged
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
Codex ReviewOverviewThis PR ensures Combobox ARIA attributes are present during SSR and initial hydration when the input ref is not yet available. It also adds targeted server-rendering tests to lock in expected combobox attributes for input-based and trigger-based configurations. Findings (None)No blocking issues found in this patch. Confidence: 4/5The behavioral change is small, directly addresses the SSR ref-timing gap, and is backed by focused regression tests on the relevant attribute paths. Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the attributes are present before hydration.
<Combobox.Trigger>has an existing mismatch if it's not inside the popup, but the issue is minor and can be worked around externally