Skip to content

[combobox] Preserve inline input on Enter without highlight#4235

Merged
atomiks merged 1 commit intomui:masterfrom
atomiks:codex/fix-combobox-inline-enter-4204
Mar 2, 2026
Merged

[combobox] Preserve inline input on Enter without highlight#4235
atomiks merged 1 commit intomui:masterfrom
atomiks:codex/fix-combobox-inline-enter-4204

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Mar 2, 2026

Pressing Enter with no highlighted item called setOpen(false), which triggered close/reset behavior and cleared inline input text. The fix skips that close call in inline mode, so Enter now leaves the typed value unchanged unless an item is actually highlighted and selected.

Fixes #4204

@atomiks atomiks added type: bug It doesn't behave as expected. component: combobox Changes related to the combobox component. labels Mar 2, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 2, 2026

commit: e620820

@mui-bot
Copy link

mui-bot commented Mar 2, 2026

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 🔺+12B(0.00%) 🔺+4B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Mar 2, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit e95a146
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69a531067438370008c48909
😎 Deploy Preview https://deploy-preview-4235--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the codex/fix-combobox-inline-enter-4204 branch from 3f5270d to e95a146 Compare March 2, 2026 06:41
@atomiks atomiks merged commit 66a97d2 into mui:master Mar 2, 2026
22 checks passed
@atomiks atomiks deleted the codex/fix-combobox-inline-enter-4204 branch March 2, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: combobox Changes related to the combobox component. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[combobox] Pressing enter on inline combobox should not reset input value

3 participants