Skip to content

[drawer] Unmark Drawer preview#4293

Merged
atomiks merged 1 commit intomui:masterfrom
atomiks:codex/unmark-drawer-preview
Mar 12, 2026
Merged

[drawer] Unmark Drawer preview#4293
atomiks merged 1 commit intomui:masterfrom
atomiks:codex/unmark-drawer-preview

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Mar 10, 2026

Summary

  • Promote the drawer namespace to stable Drawer.
  • Remove DrawerPreview entirely as a breaking API change.
  • Remove preview wording from the docs and update drawer examples and tests to use the stable import.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 10, 2026

commit: 25669d9

@atomiks atomiks added component: drawer Changes related to the drawer component. breaking change Introduces changes that are not backward compatible. labels Mar 10, 2026
@mui-bot
Copy link

mui-bot commented Mar 10, 2026

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react ▼-7B(0.00%) ▼-2B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@atomiks atomiks force-pushed the codex/unmark-drawer-preview branch from 2fff5e3 to 04eef9a Compare March 10, 2026 05:28
@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 2fff5e3
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69afab8ede90c10008398886
😎 Deploy Preview https://deploy-preview-4293--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 5cab057
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69b29ebe1e922e000708a42c
😎 Deploy Preview https://deploy-preview-4293--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks
Copy link
Contributor Author

atomiks commented Mar 10, 2026

Codex Review

Overview

This patch promotes Drawer from the preview namespace to the stable Drawer export and updates the docs, demos, tests, and experiments to use the new name. It also changes the components index badge from Preview to New so the docs still call out Drawer as recently introduced.

Findings (None)

No blocking issues found in this patch.

Confidence: 5/5

I reviewed the full upstream/master...HEAD diff and did a second pass across rendering behavior, accessibility/semantics, API shape, maintainability, performance risk, and test coverage. I also reran pnpm typescript, pnpm test:jsdom Drawer --no-watch, and pnpm test:chromium Drawer --no-watch on the current rebased branch; all passed.

@atomiks atomiks force-pushed the codex/unmark-drawer-preview branch from 04eef9a to c470424 Compare March 10, 2026 05:44
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, congrats. 👏
WDYT, would keeping the alias export make sense to avoid the BC? 🤔

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 10, 2026
@atomiks atomiks force-pushed the codex/unmark-drawer-preview branch from c470424 to 7c27444 Compare March 11, 2026 06:21
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 11, 2026
@atomiks atomiks mentioned this pull request Mar 12, 2026
@atomiks atomiks force-pushed the codex/unmark-drawer-preview branch from d771495 to 1f00b6a Compare March 12, 2026 11:07
@atomiks atomiks force-pushed the codex/unmark-drawer-preview branch from 1f00b6a to 5cab057 Compare March 12, 2026 11:08
@atomiks atomiks merged commit bb8140e into mui:master Mar 12, 2026
22 checks passed
@atomiks atomiks deleted the codex/unmark-drawer-preview branch March 12, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. component: drawer Changes related to the drawer component.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants