[docs] Fix style prop docs generation#4406
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
85b32e1 to
ae12cd9
Compare
style prop docs generation
Codex Review (GPT-5.4)1. Bugs / Issues (None)No concrete correctness bug stood out in the final branch diff. No blocking issues found in this patch. 2. Pattern Consistency Assessment
3. Simplification OpportunitiesNo meaningful simplification change stands out here. The large file count is mostly generated or mechanical churn driven by a small central typing/docs fix. 4. Edge Cases Worth Noting
5. Test Coverage AssessmentStrengths:
Gaps:
Merge Confidence Score
Overall merge confidence is 4/5. This looks safe to merge, and one small composite-style regression test would make the follow-up fix more durable. |
style prop docs generationstyle prop docs generation
|
0.37% bundle size increase for that kind of fix is so sad 😢 |
@flaviendelangle Tried this with codex and here's the comparison:
|
| { | ||
| "name": "AccordionHeader", | ||
| "description": "A heading that labels the corresponding panel.\nRenders an `<h3>` element.", |
There was a problem hiding this comment.
I think these files were intentionally removed by docs-infra upgrades? @mj12albert
In
BaseUIComponentProps, style isn't omitted like className even though we redeclared it:base-ui/packages/react/src/utils/types.ts
Line 39 in 350b6b1
It should also be excluded from
elementPropslike className when passing to useRenderElementThough this doesn't seem to cause any actual type errors but in the docs the description is missing: