[internal] Fix use of ellipses#4445
Conversation
Bundle size report
Check out the code infra dashboard for more information about this PR. |
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Placeholders are not supposed to signal emptiness. The best way to signal emptiness, is to have an empty input. Placeholders are intended to provide a clue about the expected data format or type. Therefore, an ellipsis is hardly ever appropriate in a placeholder. Placeholders don't make sense in Select. Since placeholders are intended to provide a clue about the expected data format or type, they only make sense when there is user-generated input. Select doesn't support user-generated input, so placeholders are redundant. ARIA guides advise against using placeholders as a prompt. So, I'll merge this but it's just moving food around the plate. There are a lot of mistakes throughout the docs. |
Finish the work from #3633 (comment) (I have 5 other PRs open across the codebase 😁).
...to…There is a larger discussion on whether we want to change the current standard: placeholders have no … to match with https://vercel.com/design/guidelines#placeholders-signal-emptiness. However, Vercel's UI or Shadcn UI is not even following this. Overall, it feels like we should stick to the current practice: avoid … whenever it's redundant, only for:
Similar assets: