Skip to content

[internal] Fix use of ellipses#4445

Merged
colmtuite merged 2 commits intomui:masterfrom
oliviertassinari:fix-redundant-design-clues
Mar 25, 2026
Merged

[internal] Fix use of ellipses#4445
colmtuite merged 2 commits intomui:masterfrom
oliviertassinari:fix-redundant-design-clues

Conversation

@oliviertassinari
Copy link
Copy Markdown
Member

@oliviertassinari oliviertassinari commented Mar 25, 2026

Finish the work from #3633 (comment) (I have 5 other PRs open across the codebase 😁).

  1. Fix a few more ... to
  2. Remove … for the multi-select to be consistent with the other demos on the page https://base-ui.com/react/components/select.

There is a larger discussion on whether we want to change the current standard: placeholders have no … to match with https://vercel.com/design/guidelines#placeholders-signal-emptiness. However, Vercel's UI or Shadcn UI is not even following this. Overall, it feels like we should stick to the current practice: avoid … whenever it's redundant, only for:

  • There is an action in progress
  • There is another action to take, and that is not very obvious from the other clues.

Similar assets:

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. type: bug It doesn't behave as expected. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. internal Behind-the-scenes enhancement. Formerly called “core”. labels Mar 25, 2026
@oliviertassinari oliviertassinari changed the title [internal ]Fix redundant design clues [internal] Fix redundant design clues Mar 25, 2026
@mui-bot
Copy link
Copy Markdown

mui-bot commented Mar 25, 2026

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 25, 2026

commit: 4e604cd

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 25, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 4e604cd
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69c3f54874c9c80008a5b160
😎 Deploy Preview https://deploy-preview-4445--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@oliviertassinari oliviertassinari changed the title [internal] Fix redundant design clues [internal] Fix use of ellipses Mar 25, 2026
@colmtuite
Copy link
Copy Markdown
Contributor

Placeholders are not supposed to signal emptiness. The best way to signal emptiness, is to have an empty input. Placeholders are intended to provide a clue about the expected data format or type. Therefore, an ellipsis is hardly ever appropriate in a placeholder.

Placeholders don't make sense in Select. Since placeholders are intended to provide a clue about the expected data format or type, they only make sense when there is user-generated input. Select doesn't support user-generated input, so placeholders are redundant. ARIA guides advise against using placeholders as a prompt.

So, I'll merge this but it's just moving food around the plate. There are a lot of mistakes throughout the docs.

@colmtuite colmtuite merged commit 5d44c48 into mui:master Mar 25, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. internal Behind-the-scenes enhancement. Formerly called “core”. type: bug It doesn't behave as expected. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants