[test] Inline merge-base baseline in CircleCI benchmark job#4618
Draft
Janpot wants to merge 13 commits intomui:masterfrom
Draft
[test] Inline merge-base baseline in CircleCI benchmark job#4618Janpot wants to merge 13 commits intomui:masterfrom
Janpot wants to merge 13 commits intomui:masterfrom
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,180.25 ms ▼-334.90 ms(-22.1%) | Renders: 53 (+0) | Paint: 1,848.53 ms ▼-497.42 ms(-21.2%)
...and 7 more. View full report Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Janpot
changed the title
github-actions
Bot
added
the
PR: out-of-date
Janpot
force-pushed
the
test/mui-public-1312-preview
branch
from
796c112 to
1b53e0b
Compare
github-actions
Bot
added
PR: out-of-date
Install the pkg.pr.new preview build of @mui/internal-benchmark from mui/mui-public#1312 in test/performance, and set CI_REPORT_API_URL on the CircleCI test_benchmark job to the render.com preview of code-infra-dashboard for that PR, so uploads exercise the new base- field round-trip end-to-end.
Rebuild the workflow from mui/mui-public#1312 in base-ui's CircleCI test_benchmark job: compute the merge-base with origin/master, run benchmarks in a git worktree at that commit, then run head benchmarks with BENCHMARK_BASELINE_PATH pointing at the baseline results file. BASH_ENV carries the env var across steps so the head step stays a plain pnpm test:benchmark. Master pipelines short-circuit before the fetch. Also bumps the pkg.pr.new pin from 8776a83 to 8d6d2cc.
Janpot
force-pushed
the
test/mui-public-1312-preview
branch
from
ecbc6ee to
74d176d
Compare
github-actions
Bot
removed
the
PR: out-of-date
Janpot
added
the
scope: code-infra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the CircleCI `test_benchmark` job to inline a baseline report into the head upload: