[core] Mark date-fns peer dependencies as optional#4639
Merged
LukasTy merged 2 commits intomui:masterfrom Apr 17, 2026
Merged
Conversation
The `date-fns` and `@date-fns/tz` peer dependencies are only used by the opt-in internal temporal adapter at `./internals/temporal-adapter-date-fns`. No public component requires them, and the sibling `luxon` adapter is not listed as a peer dependency at all. Mark them as optional so that consumers who don't use the adapter don't see install-time warnings. Fixes mui#4632
commit: |
Bundle size
PerformanceTotal duration: 1,417.95 ms 🔺+165.04 ms(+13.2%) | Renders: 53 (+0) | Paint: 2,184.67 ms 🔺+230.27 ms(+11.8%)
...and 7 more. View full report Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LukasTy
added
type: bug
LukasTy
requested review from
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
The `date-fns` and `@date-fns/tz` entries in `docs/package.json` are no longer imported anywhere in docs after the Calendar demos were removed in mui#4505.
atomiks
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
date-fnsand@date-fns/tzas optional peer dependencies in@base-ui/react. They're only used by the opt-in internal adapter at./internals/temporal-adapter-date-fns; no public component requires them, and the siblingluxonadapter isn't listed as a peer dep at all. Consumers who don't import the adapter now install Base UI without peer-dep warnings.date-fnsand@date-fns/tzdirect dependencies fromdocs/package.json(orphaned after the Calendar demos were removed in [internals] Move the exported internals to a new folder and remove private Calendar component #4505).Fixes #4632
Test plan
@base-ui/reactin a fresh project withoutdate-fns/@date-fns/tzand confirm no peer-dependency warningsdate-fns/@date-fns/tzpresent and confirm the version constraint is still validated