[docs] Highlight Releases sidenav item on version subpages#4651
Open
LukasTy wants to merge 2 commits intomui:masterfrom
Open
[docs] Highlight Releases sidenav item on version subpages#4651LukasTy wants to merge 2 commits intomui:masterfrom
LukasTy wants to merge 2 commits intomui:masterfrom
Conversation
The sidebar's active state used an exact pathname match, so visiting a version subpage like /react/overview/releases/v1-4-0 left the "Releases" item inactive. Match descendant paths as well so the parent stays active. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
commit: |
LukasTy
added
docs
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
LukasTy
requested review from
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
Bundle size
PerformanceTotal duration: 1,685.06 ms 🔺+292.89 ms(+21.0%) | Renders: 53 (+0) | Paint: 2,594.64 ms 🔺+434.02 ms(+20.1%)
...and 7 more. View full report Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docs sidebar used an exact pathname match to decide the active item, so visiting a version subpage such as
/react/overview/releases/v1-4-0left the "Releases" entry inactive — readers lost their place in the nav.This updates
SideNav.Itemto also treat a nav item as active when the current pathname is a descendant of itshref:The trailing
/guard prevents spurious matches (e.g.releases-archivewould not count as a child ofreleases).Why this is safe
All other sidebar sections (Overview, Handbook, Components, Utils) list flat leaf pages — no sibling href is a prefix of another, and
releases/is the only section with rendered subpages that are not themselves sidebar items. External items use full URLs, so the newstartsWithcheck cannot match app pathnames.Test plan
/react/overview/releases— "Releases" highlighted./react/overview/releases/v1-4-0— "Releases" highlighted (data-active/aria-currentset)./react/overview/releases/v1-0-0-beta-7— "Releases" highlighted./react/overview/quick-start— only "Quick start" highlighted./react/components/accordion— only "Accordion" highlighted.🤖 Generated with Claude Code