Open
Conversation
lyzno1
requested review from
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
commit: |
Bundle size
PerformanceTotal duration: 1,126.12 ms ▼-143.37 ms(-11.3%) | Renders: 53 (+0) | Paint: 1,740.88 ms ▼-233.71 ms(-11.8%)
...and 7 more. View full report Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
lyzno1
force-pushed
the
codex/docs-animation-tests
branch
from
5301456 to
5ff6858
Compare
lyzno1
force-pushed
the
codex/docs-animation-tests
branch
from
5ff6858 to
39c8933
Compare
Contributor
Author
|
@atomiks Is this the intended public way to disable Base UI animation waiting in test environments? I’d like to use it in my own project, but it wasn’t documented yet. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
globalThis.BASE_UI_ANIMATIONS_DISABLED = truein test setup files.Why
Closes #4313.
Validation
pnpm exec markdownlint-cli2 'docs/src/app/\(docs\)/react/handbook/animation/page.mdx'pnpm exec prettier --check "docs/src/app/(docs)/react/handbook/animation/page.mdx"