[otp field] Fire onValueComplete for full paste#4690
Merged
Conversation
atomiks
added
component: otp field
type: bug
ChatGPT Codex Connector
commit: |
Bundle size
PerformanceTotal duration: 1,306.40 ms 🔺+74.42 ms(+6.0%) | Renders: 53 (+0) | Paint: 2,047.19 ms 🔺+128.21 ms(+6.7%)
…and 7 more — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
requested review from
LukasTy,
colmtuite,
flaviendelangle and
michaldudak
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4679
Pasting a full OTP over an already complete value kept the field complete but skipped
onValueCompletebecause completion was only queued when the previous value was incomplete. This keeps the existing transition behavior and adds a paste-specific path for complete-to-complete pastes, including when the pasted value matches the current value.Changes
onValueCompletefor complete paste interactions while the field is already complete.