[popover] Preserve active trigger on close press#4741
Merged
mj12albert merged 2 commits intoMay 5, 2026
Conversation
mj12albert
added
component: popover
mj12albert
force-pushed
the
fix-popover-close-event-trigger
branch
from
dbf4c3f to
178086f
Compare
commit: |
Bundle size
PerformanceTotal duration: 1,178.40 ms ▼-147.68 ms(-11.1%) | Renders: 53 (+0) | Paint: 1,843.52 ms ▼-203.04 ms(-9.9%)
…and 7 more — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mj12albert
force-pushed
the
fix-popover-close-event-trigger
branch
from
178086f to
0e09f04
Compare
mj12albert
force-pushed
the
fix-popover-close-event-trigger
branch
from
0e09f04 to
96804a4
Compare
mj12albert
requested review from
LukasTy,
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
atomiks
approved these changes
May 5, 2026
Contributor
|
@mj12albert Tested locally and working. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4738
Preview: https://stackblitz.com/edit/8gvbf1wk-64lb8vbx?file=src%2Findex.module.css
Follows Dialog by preserving the active trigger when PopoverClose closes the popup