[toast] Reuse getDisplacement function #4748
Merged
Merged
Conversation
sai6855
added
type: enhancement
commit: |
Bundle size
PerformanceTotal duration: 1,340.65 ms +19.37 ms(+1.5%) | Renders: 53 (+0) | Paint: 2,051.43 ms -3.07 ms(-0.1%)
…and 7 more — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sai6855
requested review from
LukasTy,
colmtuite,
flaviendelangle and
michaldudak
as code owners
There was a problem hiding this comment.
Pull request overview
This PR deduplicates swipe displacement logic in the Toast component by removing a locally-defined getDisplacement helper and reusing the shared implementation from utils/useSwipeDismiss, keeping behavior consistent across swipe-dismiss consumers.
Changes:
- Import
getDisplacementfrompackages/react/src/utils/useSwipeDismiss. - Remove the inline
getDisplacementimplementation fromToastRoot.tsx.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
atomiks
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although
getDisplacementutility isn’t specific to Toast, the logic matches exactly, so I reused it