[otp field] Ignore hidden-input changes while readonly or disabled#4806
Merged
atomiks merged 2 commits intoMay 11, 2026
Merged
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,068.37 ms ▼-129.45 ms(-10.8%) | Renders: 50 (+0) | Paint: 1,622.77 ms ▼-207.21 ms(-11.3%)
…and 7 more — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
approved these changes
May 11, 2026
Contributor
atomiks
left a comment
There was a problem hiding this comment.
Thanks for the fix @lunaxislu
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4805
Summary
OTPField.Inputalready ignores changes while the field isreadOnlyordisabled, but the hidden validation input rendered byOTPField.Rootstill acceptedchangeevents.This patch applies the same guard to the hidden input's
onChangehandler so locked OTP fields cannot be updated through that path.Why
There is already existing coverage for hidden-input autofill, so this aligns the locked-state behavior across both input paths instead of changing the intended hidden-input flow.
Changes
disabled || readOnlyguard to the hidden validation inputonChangeTesting
pnpm test:jsdom OTPField --no-watchpnpm test:chromium OTPField --no-watch