[internal] useLayoutEffect with ResizeObserver#4814
Open
romgrk wants to merge 1 commit into
Open
Conversation
romgrk
added
the
type: enhancement
romgrk
requested review from
LukasTy,
colmtuite,
flaviendelangle and
michaldudak
as code owners
commit: |
Bundle size
PerformanceTotal duration: 1,053.58 ms -38.58 ms(-3.5%) | Renders: 50 (+0) | Paint: 1,622.59 ms -41.20 ms(-2.5%) No significant changes. Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
oliviertassinari
changed the title
useLayoutEffect with ResizeObserveruseLayoutEffect with ResizeObserver
Member
flaviendelangle
left a comment
flaviendelangle
left a comment
There was a problem hiding this comment.
Worth double checking, but I think the registerTabResizeObserverElement in TabsTab should also be a layout effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we use
useLayoutEffectwithResizeObserver.