[tabs] Add keepMounted prop to TabsRoot#4830
Open
sarthakmalik0810 wants to merge 1 commit into
Open
Conversation
sarthakmalik0810
requested review from
LukasTy,
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
commit: |
Bundle size
PerformanceTotal duration: 1,286.23 ms +66.20 ms(+5.4%) | Renders: 50 (+0) | Paint: 1,958.95 ms +73.41 ms(+3.9%)
8 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sarthakmalik0810
force-pushed
the
tabs-root-add-keep-mounted
branch
2 times, most recently
from
6f29c2c to
22d4edb
Compare
oliviertassinari
added
the
component: tabs
sarthakmalik0810
force-pushed
the
tabs-root-add-keep-mounted
branch
from
22d4edb to
dd6bdb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4822
Add
keepMountedprop to<Tabs.Root />. Can be overridden per panel withkeepMountedon<Tabs.Panel />