[drawer] Forward viewport style prop#4841
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,075.90 ms -144.13 ms(-11.8%) | Renders: 50 (+0) | Paint: 1,648.05 ms -237.49 ms(-12.6%)
11 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code Review: #4841 — [drawer] Forward viewport style propOverviewFixes a bug where Verification performed
Code quality & conventions
Minor notes (non-blocking)
RisksEffectively none. The change is purely additive — it restores a previously-dropped prop. No security, performance, or API-surface concerns. Verdict: Looks good to merge. Small, correct, well-tested bug fix with a verified regression test. |
Drawer.Viewport now forwards the
styleprop to the rendered viewport, matching the rest of the component API and keeping conformance coverage in place.Root cause
Drawer.Viewportdestructuredstylebut never passed it toDialogViewport, so styles set on the component were dropped.Changes
stylefromDrawer.ViewporttoDialogViewport.Drawer.Viewport.