[docs] Fix format of OTP Field in changelog#4846
Open
oliviertassinari wants to merge 1 commit into
Open
Conversation
oliviertassinari
added
type: bug
commit: |
Bundle size
PerformanceTotal duration: 1,237.98 ms -207.94 ms(-14.4%) | Renders: 50 (+0) | Paint: 1,910.10 ms -278.75 ms(-12.7%)
…and 2 more (+5 within noise) — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
pnpm release:changeloggenerates## Otp Field.After it generates
## OTP Fieldas we expect in #4850.Context: I noticed this as I was curious to see how the changelog would explain how to handle the breaking changes from #4717. Would it explain what changed, closer to https://github.com/mui/mui-x/releases/tag/v9.0.0, or would it be unclear?
So far, it's unclear by default; the same goes for the description in #4717. So, the first step seems to have a clear breaking change section on our PR descriptions. The second step could be to automate the extraction of it for the changelog, but that might be overkill. Anyway, I thought I might open a PR, the time-consuming part was to test how it behaves; the fix is simple.