SvgIcon viewBox hardcoded

[ruswerner]

I am trying to use an existing SVG icon with the svg-icon.jsx component, and the viewBox is hardcoded to 0 0 24 24 which crops out my icon. My icon is drawn on a larger scale and needs a different view box to be set. I couldn't see a way to affect this property and I'd rather not rescale all my icon assets to the 24px view box.

Do you recommend extending this component, or do you think this should be configurable?

Thanks!

[ruswerner]

I was able to make this work by changing the render method to this:

render: function() {

  var {
    viewBox,
    style,
    ...other
  } = this.props;

  return (
    <svg
      {...other}
      viewBox={viewBox||"0 0 24 24"}
      style={this.mergeAndPrefix(
        this.getStyles(),
        this.props.style)}>
          {this.props.children}
    </svg>
  );
}

[ruswerner]

I'm not sure why else you would have extracted viewBox from this.props and then not use it anywhere...