[ButtonBase] Fix accessibility#10434
Merged
oliviertassinari merged 1 commit intoFeb 24, 2018
Merged
Conversation
oliviertassinari
added
accessibility
mbrookes
reviewed
Feb 24, 2018
| {[0, 1, 2, 3].map(value => ( | ||
| <ListItem | ||
| key={value} | ||
| role={undefined} |
Member
There was a problem hiding this comment.
Could ListItem take care of this?
Member
Author
There was a problem hiding this comment.
It's specific to having the Checkbox inside. The warning is around this invalid DOM structure role=button > input. I'm generally against abstracting the i11y for anything that requires non trivial code. Non trivial code is increasing the bug surface area + the bundle size, for a relative slight added value.
Member
There was a problem hiding this comment.
👍 Perhaps code comment then?
Member
Author
There was a problem hiding this comment.
I believe it's not important and that 98% of the people won't care. But why not. I couldn't see an easy way to document it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
role="button"on non<button>elements.spacekey event.Closes #10339