Skip to content

[internal] Improve support for extended props in theme#25934

Merged
mnajdova merged 35 commits intomui:nextfrom
vicasas:feature/support-custom-part2
Apr 26, 2021
Merged

[internal] Improve support for extended props in theme#25934
mnajdova merged 35 commits intomui:nextfrom
vicasas:feature/support-custom-part2

Conversation

@vicasas
Copy link
Copy Markdown
Member

@vicasas vicasas commented Apr 24, 2021

Added support custom for

  • Autocomplete -> size
  • Table -> size
  • ToggleButton -> size
  • ToggleButtonGroup -> size
  • Slider -> color
  • Pagination -> color, size
  • PaginationItem -> color, size
  • Fab -> color, size
  • SvgIcon -> color, size
  • Icon -> color, size
  • Chip -> color, size
  • InputBase -> color
  • OutlinedInput -> color
  • FilledInput -> color
  • Input -> color
  • Switch -> color, size
  • Checkbox -> color, size
  • Radio -> color, size

Closes #13875

@mui-pr-bot
Copy link
Copy Markdown

mui-pr-bot commented Apr 24, 2021

Details of bundle changes

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%

Generated by 🚫 dangerJS against fedb770

@oliviertassinari oliviertassinari changed the title [ToggleButton][ToggleButtonGroup][Table][Autocomplete] Support custom sizes [core] Improve support for extended props in theme Apr 24, 2021
@oliviertassinari oliviertassinari added internal Behind-the-scenes enhancement. Formerly called “core”. type: new feature Expand the scope of the product to solve a new problem. labels Apr 24, 2021
@vicasas
Copy link
Copy Markdown
Member Author

vicasas commented Apr 24, 2021

@oliviertassinari I'll keep uploading a few more commits.

@vicasas
Copy link
Copy Markdown
Member Author

vicasas commented Apr 24, 2021

I don't understand why the ci was broken in TableContext, TableCell since no changes have been made to them.

@vicasas
Copy link
Copy Markdown
Member Author

vicasas commented Apr 24, 2021

I don't understand why the ci was broken in TableContext, TableCell since no changes have been made to them.

I already understood, repairing...

@oliviertassinari I have the correction ready but before committing I wonder if we should better revert this change. 617802e

Update: I pushed the fix in this commit de467cc

@vicasas
Copy link
Copy Markdown
Member Author

vicasas commented Apr 24, 2021

I think there are 3 pending. I will continue later here or in another PR.

Comment thread framer/scripts/framerConfig.js
@vicasas
Copy link
Copy Markdown
Member Author

vicasas commented Apr 25, 2021

@oliviertassinari I think I need help on the last 3 missing components (Switch, Checkbox, Radio). For hours I have tried to deal with framer's mistakes without success.

@oliviertassinari
Copy link
Copy Markdown
Member

@vicasas Ok, it should be fixed now. It also seems that you handled all the cases, I have marked the issue as closed by this PR :)

@vicasas
Copy link
Copy Markdown
Member Author

vicasas commented Apr 25, 2021

@oliviertassinari Thanks!! I will finish the last two remaining Checkbox and Radio and we are ready.

@vicasas
Copy link
Copy Markdown
Member Author

vicasas commented Apr 25, 2021

With this last commit they would all be done. 💯🚀

@github-actions github-actions Bot added PR: out-of-date The pull request has merge conflicts and can't be merged. labels Apr 26, 2021
Copy link
Copy Markdown
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks @vicasas

@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 26, 2021
Comment thread packages/material-ui/src/Table/Table.d.ts Outdated
@mnajdova mnajdova merged commit 1d3b2af into mui:next Apr 26, 2021
@oliviertassinari oliviertassinari changed the title [core] Improve support for extended props in theme [internal] Improve support for extended props in theme Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[theme] Allow custom color variants

4 participants