Skip to content

[internal][pickers] Move useInterceptProps into module#26090

Merged
eps1lon merged 4 commits intomui:nextfrom
eps1lon:chore/pickers/drop-config
May 3, 2021
Merged

[internal][pickers] Move useInterceptProps into module#26090
eps1lon merged 4 commits intomui:nextfrom
eps1lon:chore/pickers/drop-config

Conversation

@eps1lon
Copy link
Copy Markdown
Member

@eps1lon eps1lon commented May 2, 2021

Removes the *config objects in favor of ES modules.

Will handle lint and other pickers later. Just want to get a look at bundle size. Edit:
What I expected:

StaticDatePicker ▼ -55.7 kB (-25.29% ) 165 kB ▼ -16 kB (-22.65% ) 54.7 kB
MobileDatePicker ▼ -26.8 kB (-12.20% ) 193 kB ▼ -8.54 kB (-12.08% ) 62.1 kB
DesktopDatePicker ▼ -25.5 kB (-11.62% ) 194 kB ▼ -5.9 kB (-8.35% ) 64.7 kB
@material-ui/lab ▼ -210 B (-0.05% ) 387 kB ▲ +22 B (+0.02% ) 116 kB
DatePicker ▼ -106 B (-0.05% ) 220 kB ▲ +106 B (+0.15% ) 70.8 kB

@eps1lon eps1lon added performance scope: pickers Changes related to the date/time pickers. labels May 2, 2021
@mui-pr-bot
Copy link
Copy Markdown

mui-pr-bot commented May 2, 2021

Details of bundle changes

@material-ui/lab: parsed: -0.18% 😍, gzip: -0.04% 😍

Generated by 🚫 dangerJS against 4aaba71

@eps1lon eps1lon force-pushed the chore/pickers/drop-config branch from 09926e6 to e8b7b54 Compare May 3, 2021 07:55
@eps1lon eps1lon force-pushed the chore/pickers/drop-config branch from e8b7b54 to 4aaba71 Compare May 3, 2021 08:04
@eps1lon eps1lon marked this pull request as ready for review May 3, 2021 10:16
@eps1lon eps1lon merged commit 3850907 into mui:next May 3, 2021
@eps1lon eps1lon deleted the chore/pickers/drop-config branch May 3, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance scope: pickers Changes related to the date/time pickers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants