[Stack] Ensure that marginundefined doesn't occur in styling #33548
Merged
hbjORbj merged 7 commits intomui:masterfrom Jul 20, 2022
Merged
[Stack] Ensure that marginundefined doesn't occur in styling #33548hbjORbj merged 7 commits intomui:masterfrom
marginundefined doesn't occur in styling #33548hbjORbj merged 7 commits intomui:masterfrom
Conversation
hbjORbj
added
type: bug
2 tasks
mnajdova
reviewed
Jul 18, 2022
mnajdova
reviewed
Jul 19, 2022
hbjORbj
force-pushed
the
fix/stack-direction-prop
branch
from
7d49ca8 to
f4d3d6f
Compare
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32196
Problem:
directionprop receives a responsive value such that it doesn't start with the smallest breakpoint, such asdirection={{ lg: 'row' }}, for the breakpoints belowlg,"marginundefined": "0px"is being used in styling instead of"marginLeft": "0px"(forrowdirection) or"marginTop": "0px"(forcolumndirection).undefinedbecausedirectionValues[breakpoint]in the next line, line 87, isundefined.Solution:
undefined, by ensuring thatdirectionValues[breakpoint]in the next line, line 87, is notundefined.Codesandboxes:
Before
After